Repo homepage tweaks #32759
Repo homepage tweaks #32759
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
GiteaBot
added
lgtm/need 1
|
Why I added See: |
|
Yes, that's why I increased the media query so it no longer shows like that. Long-term we should refactor from table to flexbox/grid because tables just suck for layouting. |
No, I got this screen shot from this PR.
|
|
Hmm maybe this is dependant on font size or something. For me, the table limit was at 872px. |
| @@ -24,7 +24,7 @@ | |||
| border-top: 1px solid var(--color-secondary); /* same to .flex-list > .flex-item + .flex-item */ | |||
| } | |||
|
|
|||
| @media (max-width: 767.98px) { | |||
| @media (max-width: 872px) { /* value is exactly where the file table starts to overflow */ | |||
There was a problem hiding this comment.
In my case, at least around 911px is necessary.
monitor is 1080p, OS is windows, browser is Chrome latest version
There was a problem hiding this comment.
I would never believe such pixel-level fine-tuning could be right ......
There was a problem hiding this comment.
It's not, but this table is a huge pixel hack to begin with, and tables are very hard to get responsive.
There was a problem hiding this comment.
Actually this fix is a pixel-level fine-tuning.
And I think the root reason it table's width is not correctly calculated, so simply adjust max-width is not right.
If you think this is a pixel-level fine-tuning, then I will give you a more simplify example:
If there's only Description, you will see:
|
The root problem is that there were so many hacky patches. A clear solution should be completely rewriting these styles.
|
|
Yes, but I'm not sure I played around with these styles earlier and some of them didn't do anything. |
|
It should be like this: Fix repo home file list #32788 |
fixedtable layout. The non-fixed layout causes overflow issue between 872px and 768px width, fix that by switching to the mobile layout at 872px..repository-summaryto search bar in height: